Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NCBI Protein #1061

Open
IgorRodchenkov opened this issue Mar 24, 2024 · 1 comment
Open

Update NCBI Protein #1061

IgorRodchenkov opened this issue Mar 24, 2024 · 1 comment
Assignees
Labels
Update Used in combination with prefix, metaprefix, or collection for updates to entries

Comments

@IgorRodchenkov
Copy link

Prefix

ncbiprotein

Explanation

I was digging/cleaning into DrugBank data. They have things like this

<external-identifier>
     <resource>GenBank Protein Database</resource>
     <identifier>33150626</identifier>
 </external-identifier>

I had to try/guess the standard ID collection/prefix to use but I found that e.g. both bioregistry.io/ncbiprotein:33150626 and bioregistry.io/genbank:33150626 get successfully resolved to https://www.ncbi.nlm.nih.gov/protein/33150626.

I think "ncbiprotein:33150626" CURI is wrong and should return a pattern mismatch error instead, no?

Contributor ORCID

Igor Rodchenkov

@IgorRodchenkov IgorRodchenkov added the Update Used in combination with prefix, metaprefix, or collection for updates to entries label Mar 24, 2024
@cthoyt
Copy link
Member

cthoyt commented Mar 25, 2024

Hi @IgorRodchenkov, thanks for looking into this. NCBI Protein is a special resource - from what I can tell, it is enabling resolving of a variety of other resource types. Can you give a bit more context on what drugbank entry this comes from, and what the expected protein it is supposed to point to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Used in combination with prefix, metaprefix, or collection for updates to entries
Projects
None yet
Development

No branches or pull requests

2 participants