Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge resource GlyGen into GlyTouCan #1084

Open
katewarner opened this issue Apr 8, 2024 · 3 comments · May be fixed by #1109
Open

Merge resource GlyGen into GlyTouCan #1084

katewarner opened this issue Apr 8, 2024 · 3 comments · May be fixed by #1109
Assignees
Labels
Merge When considering merging two entries Update Used in combination with prefix, metaprefix, or collection for updates to entries

Comments

@katewarner
Copy link

Redundant Prefix

glygen

Target Prefix

glytoucan

Explanation

The local unique identifier in the GlyGen prefix is actually a GlyTouCan ID, as we use these IDs to identify Glycans in GlyGen.

Contributor ORCID

0000-0001-8705-181X

@katewarner katewarner added Merge When considering merging two entries Update Used in combination with prefix, metaprefix, or collection for updates to entries labels Apr 8, 2024
@bgyori
Copy link
Contributor

bgyori commented May 3, 2024

Hi @katewarner, I think this makes sense. Interestingly, two other registries, Fairsharing, and Integbio also have separate entries for GlyGen and GlyToucan. In any case, what we could do is, keep the glytoucan prefix, but add glygen as a synonym prefix, and also list GlyGen as a "provider" for GlyToucan IDs.

@bgyori bgyori linked a pull request May 3, 2024 that will close this issue
@matentzn
Copy link
Collaborator

matentzn commented May 5, 2024

From the little bit of information in this issue the complete solution comes down to the question of whether the org behind https://glygen.org/ (@jeet-vora) agrees with the assertion that the local id corresponds to a GlyTouCan ID. Right now, both glytoucan and glygen are registered as separate “semantic spaces” covering the same exact local ID space (as far as I can quickly see from the regex rules in both records):

https://bioregistry.io/registry/glygen
https://bioregistry.io/registry/glytoucan

If @jeet-vora agrees that the local ids are in fact all glytoucan ids IMO the course of action should be to:

  1. Remove the glygen record entirely
  2. Add the glygen prefix as a prefix synonym to the glytoucan record (as @bgyori suggests)
  3. Add glygen.org as an alternative resolver (uri_prefix_synonym)
  4. While you are at it, add a point of contact to the glytoucan record

@bgyori
Copy link
Contributor

bgyori commented May 5, 2024

Thanks @matentzn, the PR I opened here #1109 implements what you are suggesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge When considering merging two entries Update Used in combination with prefix, metaprefix, or collection for updates to entries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants