-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neuinfo.org URLs not resolving #1124
Comments
I will look into those to see what is happening (ccing @jgrethe, @smtifahim). |
It looks like your code might be stripping a leading zero due to a conversion to integer and back e.g. http://uri.neuinfo.org/nif/nifstd/nlx_chem_090801 is the correct form. |
Thanks @tgbugs, it seems like the example IDs were not correctly curated when they were originally added to the Bioregistry. @tanayshah2 could you look at the example IDs for the above 3 resources and see if they can be resolved if we add back the missing leading 0s? If that works, we can just update them in bioregistry.json. |
Thanks, @tgbugs, we were able to resolve the issues with nlx.cell and nlx.chem. However, there seems to still be an issue with our example ID for nlx.dys (20090303), as http://uri.neuinfo.org/nif/nifstd/nlx_dys_20090303 leads to a 404 error. Adding the leading 0 doesn't resolve the issue in this case, do you happen to have any suggestions for potential fixes here? |
@tgbugs could you check the comment above on one remaining issue related to nlx.dys? Thanks! |
@tgbugs, @jgrethe, @smtifahim - would you mind taking a quick look at this so we can wrap up this issue? Thanks! |
Will investigate. |
In summary, I would suggest updating the test url to http://uri.neuinfo.org/nif/nifstd/nlx_dys_20090602. Not all of the old ontology classes were correctly ported to neurolex, and thus not to interlex. See SciCrunch/NIF-Ontology#223 and SciCrunch/NIF-Ontology#124 for reference. The general issue of ontology ids not being mapped in interlex should be resolved as part of our work on the next version of interlex. In detail: The test class in question is present in the ontology, the curie https://github.com/tgbugs/pyontutils/blob/master/nifstd/nifstd_tools/mapnlxilx.py the file that generates the mappings Present in ontology. Not present in interlex however, which is why the mapping for the redirect is not present. |
We found a few prefixes related to neuinfo.org where identifiers aren't resolving correctly with the following URL patterns:
For example, http://uri.neuinfo.org/nif/nifstd/nlx_chem_90801 gives a 404 error.
@tgbugs since you are listed as a contact person for these resources, do you have any suggestions what we could do? Are these URLs expected to work or should we change to a different URL pattern?
The text was updated successfully, but these errors were encountered: