Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default KISAO resolver #569

Closed
bgyori opened this issue Sep 16, 2022 · 4 comments
Closed

Update default KISAO resolver #569

bgyori opened this issue Sep 16, 2022 · 4 comments
Assignees
@cthoyt
Labels
Update Used in combination with prefix, metaprefix, or collection for updates to entries

Comments

@bgyori
Copy link
Contributor

bgyori commented Sep 16, 2022 •
edited
Loading

Prefix

biomodels.kisao

Explanation

The default resolver e.g., https://www.biomodels.net/kisao/KISAO#KISAO_0000057 doesn't work, but resolving to BioPortal or OLS does e.g., http://purl.bioontology.org/ontology/KISAO/kisao:KISAO_0000057 so one of those should be prioritized.

Contributor ORCID

0000-0001-9439-5346
@bgyori bgyori added the Update Used in combination with prefix, metaprefix, or collection for updates to entries label Sep 16, 2022
@bgyori
Copy link
Contributor Author

bgyori commented Sep 16, 2022

As a side note, I find the prefix biomodels.kisao odd since KISAO can be considered a standalone resource, not a part of BioModels. It might make sense to change the prefix to just kisao.

@bgyori
Copy link
Contributor Author

bgyori commented Sep 16, 2022

Further context: https://github.com/SED-ML/KiSAO#browsing-kisao, "KiSAO can be browsed through BioPortal and OLS."

@cthoyt
Copy link
Member

cthoyt commented Sep 16, 2022

Strange, this site used to work, since it's been manually overridden. I wonder what happened to it.

@bgyori
Copy link
Contributor Author

bgyori commented Sep 16, 2022

My guess is the resource got moved out from BioModels and is now considered standalone.

@cthoyt cthoyt closed this as completed in a9603ac Sep 17, 2022
@cthoyt cthoyt mentioned this issue Sep 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthoyt cthoyt

Labels
Update Used in combination with prefix, metaprefix, or collection for updates to entries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cthoyt @bgyori