Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any missing prefixes that could be standardised? #917

Closed
matentzn opened this issue Jul 27, 2023 · 2 comments
Closed

Any missing prefixes that could be standardised? #917

matentzn opened this issue Jul 27, 2023 · 2 comments

Comments

@matentzn
Copy link
Collaborator

The following list came out of this PR: https://github.com/mapping-commons/sssom-py/pull/397/files, as CURIES that cannot be standardised:

ABA
AEO_RETIRED
ANISEED
BAMS
BILS
BIRNLEX
BM
BSA
BilaDO
CALOHA
EHDAA2_RETIRED
EMAPA_RETIRED
FBbt_root
GAID
ILX
Image
KUPO
MAP
MESH
MIAA
NIFSTD_RETIRED
NIF_Subcellular
NLX
NLXANAT
OBO_REL
OGEM
OGES
OpenCyc
RETIRED_EHDAA2
TE
UBERONTEMP
Wikipedia
WikipediaCategory
XtroDO
ilxtr
ncithesaurus
nifext

Is this correct @cthoyt? Shouldn't we at least register some of the more widely used ones as prefix synonyms, like:

(numbers mean: occurrences in some ontology I happened to work on at the time)

Wikipedia: 477
CALOHA: 244 (the issue here seems to suggest this was, indeed, added)
MESH: 227
GAID: 191
OpenCyc: 182
MIAA: 93
BAMS: 73
BIRNLEX: 60

We can close this issue immediately, I just want to make sure the decision for not adding these and the reasoning behind it is documented again.

@cthoyt
Copy link
Member

cthoyt commented Jul 27, 2023

Yes, some of these are already registered as prefix synonyms. However, switching over to using curies.Converter in mapping-commons/sssom-py#397 did not completely rewrite the loading to begin using synonyms. That will be another larger change, and I wanted to keep them separate.

https://github.com/cthoyt/oquat is an automated tool that identifies all prefixes across all OBO Foundry ontologies that are not registered. I have put considerable effort into registering what I can, then trying to ask about ones that I could not figure out. Two main issues I ran into is that people import lots of content from other ontologies that they don't understand and further most maintainers aren't responsive and able to answer questions (I have made many many issue requests for clarification)

@matentzn
Copy link
Collaborator Author

Ahh ok, of course, we are still using bimap!

No problem then, this is all solved already!

Sorry about the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants