Appveyor fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unclear why these customizations are needed and they seem to interfere with building wheels using ./setup.py bdist_wheel.
The choco command seems to fail and the cinst command is recommended by the AppVeyor documentation.
|
No, thank you! This is awesome. I think I copied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for making this library. I noticed your work on getting AppVeyor to build windows wheels but it seems to be failing. I had to remove the customized build in
setup.pyto get it working. I'm not sure why theCustomBuildandCustomInstallwere added in the first place but they did not seem to be necessary for me. Is there a reason to keep those around?