Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensive duplication in drugbank.mixtures #13

Closed
andrewsu opened this issue Dec 21, 2017 · 5 comments
Closed

extensive duplication in drugbank.mixtures #13

andrewsu opened this issue Dec 21, 2017 · 5 comments
Assignees

Comments

@andrewsu
Copy link
Member

for example, see http://mychem.info/v1/chem/KTUFNOKKBVMGRW-UHFFFAOYSA-N?fields=drugbank,drugcentral

screenshot:
2017-12-21_9-38-04

@newgene
Copy link
Member

newgene commented Dec 19, 2018

This seems not being solved in the recent data release. More examples here:

http://mychem.info/v1/query?q=_exists_:drugbank.mixtures&fields=drugbank.mixtures,drugbank.name

@greg-k-taylor

@newgene newgene added this to the Next data release milestone Dec 19, 2018
@greg-k-taylor
Copy link
Collaborator

This patch may solve the problem. It appears inefficient (during the parsing step) but removes duplicates. Below is a link to the patch and a list of a few documents without duplicates. I spot checked DB00007, DB00008, and DB00009 which have duplicates in the current version of mychem.info.

greg-k-taylor@f294b27

Here is a short list of documents without duplicates (using the patch):
{ "_id" : "DB00007", "drugbank" : { "mixtures" : [ { "name" : "Lupaneta Pack", "ingredients" : [ "Leuprolide", "Norethisterone" ] } ] } }
{ "_id" : "DB00008", "drugbank" : { "mixtures" : [ { "name" : "Pegasys Rbv", "ingredients" : [ "Peginterferon alfa-2a", "Ribavirin" ] } ] } }
{ "_id" : "DB00009", "drugbank" : { "mixtures" : [ { "name" : "Lysatec RT - Pa", "ingredients" : [ "Alteplase", "Water" ] }, { "name" : "Activase RT-PA", "ingredients" : [ "Alteplase", "Water" ] }

@newgene
Copy link
Member

newgene commented Jan 7, 2019

Now in pull request: #57

@greg-k-taylor
Copy link
Collaborator

Pull request merged and closed.

@greg-k-taylor
Copy link
Collaborator

Ooops, not verified in production yet.

@greg-k-taylor greg-k-taylor reopened this Jan 9, 2019
@newgene newgene closed this as completed Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants