Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'base_pairs()' does not work for structures with non-standard atom-order #237

Closed
padix-key opened this issue Oct 9, 2020 · 1 comment · Fixed by #242 or #244
Closed

'base_pairs()' does not work for structures with non-standard atom-order #237

padix-key opened this issue Oct 9, 2020 · 1 comment · Fixed by #242 or #244
Labels

Comments

@padix-key
Copy link
Member

The function structure.base_pairs() gives incorrect results, in my experience missing base pairs, if the input nucleic acid structure has an order for their atoms within each residue that is different from the RCSB standard.

The reason is that a standard base is superimposed on each nucleotide:

# Match the selected std_base to the base.
fitted, transformation = superimpose(
nucleotide[np.isin(nucleotide.atom_name, std_base.atom_name)],
std_base[np.isin(std_base.atom_name, nucleotide.atom_name)]
)

Even though missing atoms are checked before the superimposition, the correct order is not.
This means that atoms can be superimposed onto each other, that are not equivalent.

@padix-key
Copy link
Member Author

This issue was falsely automatically closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant