Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer component assets #150

Closed
SheepFromHeaven opened this issue Nov 13, 2018 · 7 comments
Closed

Transfer component assets #150

SheepFromHeaven opened this issue Nov 13, 2018 · 7 comments
Assignees

Comments

@SheepFromHeaven
Copy link
Member

We should include assets in the components build process.

@jurekbarth
Copy link
Collaborator

Just images or do you expect some kind of special pattern for copying stuff?

@jurekbarth jurekbarth self-assigned this Nov 14, 2018
@timomayer
Copy link
Member

like that to bundle assets with components, downside is that we habve a lot of duplicated assets (like dummy images) in each component.
@jurekbarth when we are doing it we should consider anything. (images, videos, ...)

@SheepFromHeaven
Copy link
Member Author

@jurekbarth are you still working on that?

@jurekbarth
Copy link
Collaborator

@SheepFromHeaven it works now for the loaders with webpack, so i think we're on a good way. Please reopen if you need any additional stuff 👍

@smohadjer
Copy link
Contributor

@jurekbarth I would like to keep my component's assets with my component where other component resources are. Right now if I do so, when I run gulp serve assets can be reached, but when gulp build runs assets aren't available anymore. Can we have this fixed?

@timomayer timomayer reopened this May 21, 2019
@jurekbarth
Copy link
Collaborator

@smohadjer right now it only works if you import in typescript files. So would a data directory inside your component folder solve your needs? Because we implemented that here #193

@smohadjer
Copy link
Contributor

Typescript is here irrelevant because a component may not have any scripts to start with and still have assets. I guess we can use data folder for this purpose, though it's not really then consistent with global folder structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants