Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow freezes on previous button #2

Closed
GoogleCodeExporter opened this issue May 6, 2015 · 9 comments
Closed

Slideshow freezes on previous button #2

GoogleCodeExporter opened this issue May 6, 2015 · 9 comments

Comments

@GoogleCodeExporter
Copy link

I have noticed how the slideshow many times stops updating the image when
clicking on the previous button several times in a row (I can only go a
avout 4 images back). The counter seems to continue though as when I click
on the next button the images that appears is the image that would have
appeared if the previous button worked.
I haven't been able to recreate the problem every time as it appears to be
random.

The next button always seems to work. I have noticed the same problem for
the last and first buttons as well.

This has happened on both the demo site and my local installation.

I am using firefox 3.0b5 with the latest mootools trunk.


Original issue reported on code.google.com by m...@theglide.com on 13 May 2008 at 9:09

@GoogleCodeExporter
Copy link
Author

Can you please provide steps I can repeat to re-create the problem you are 
seeing?
Also please provide the JS / CSS you are using in your show or a link to an 
example
online.

Original comment by aeron.gl...@gmail.com on 13 May 2008 at 1:59

@GoogleCodeExporter
Copy link
Author

I sent you an email yesterday with a link to my page with the slideshow
implementation. Did you get it?

Original comment by m...@theglide.com on 14 May 2008 at 7:36

@GoogleCodeExporter
Copy link
Author

I have also noticed that I must sometimes click twice on the thumbnails before 
the
next image is loaded. This happens even when I wait a long period.

Original comment by m...@theglide.com on 14 May 2008 at 2:05

@GoogleCodeExporter
Copy link
Author

I did not receive the email. Also I will need steps to be able to re-create the
effect you are seeing before I will be able to fix it.

Original comment by aeron.gl...@gmail.com on 14 May 2008 at 2:16

@GoogleCodeExporter
Copy link
Author

Strange, I sent to the address you have listed here.
There is really not much to recreate. Just click on the thumbnails in my 
slideshow or
the prev button until nothing happens.
I will resend the e-mail now. Let me know if you haven't received it.

Thanks!

Original comment by m...@theglide.com on 14 May 2008 at 2:25

@GoogleCodeExporter
Copy link
Author

Did you get it now Aeron?

I went to http://www.electricprism.com/aeron/slideshow/ and the same problem 
appears.

This is what you do:

When you enter the page, click on Pause.
Now click on the prev button. After a few clicks the slideshow will freeze with 
the
loading indicator running endlessly.

The same thing happens by clicking on pause and then clicking backward on the
thumbnails. You will finally enter a state when the loader keeps on going.
You will also notice how very often you must click twice on the thumbnails 
before a
transition is made.

I have tested this with Firefox 3.0b5 and 2.0.14.

Hope this helps!

Original comment by m...@theglide.com on 15 May 2008 at 8:43

@GoogleCodeExporter
Copy link
Author

The problem is found on line 200 of slideshow.js.  If the slideshow is paused 
and the
image is not finished loading, preload isn't called again.  My guess as to why 
the
next button always works is that since the next image is preloaded when the 
current
image finishes loading, it passes the test on line 170.

Haven't looked long enough to know what the best solution is, but changing line 
200 to
   this.timer = this.preload.delay(100, this, fast);
seems to work.

Original comment by carqu...@cox.net on 15 May 2008 at 7:17

@GoogleCodeExporter
Copy link
Author

Thanks I will try that :)

Original comment by m...@theglide.com on 16 May 2008 at 8:55

@GoogleCodeExporter
Copy link
Author

This has been fixed in SVN

Original comment by aeron.gl...@gmail.com on 19 May 2008 at 3:04

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant