Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Handle mixed-orientation sets more gracefully #25

Closed
GoogleCodeExporter opened this issue May 6, 2015 · 3 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Slideshow doesn't handle slideshow sets containing a mix of portrait and
landscape formatted images very well.  

I'm not entirely certain what to suggest, maybe some way to dynamically
change the size of the slideshow divs if the image orientation changes?

Original issue reported on code.google.com by jonst...@gmail.com on 6 Jul 2008 at 5:11

@GoogleCodeExporter
Copy link
Author

Can you provide a URL with an example of what you think needs improvement? 
Thank you.

Original comment by aeron.gl...@gmail.com on 6 Jul 2008 at 3:13

@GoogleCodeExporter
Copy link
Author

Basically what we want is a 'resize' variant that fits the image's *longest*
dimension within the frame of the slideshow, rather the current behavior (which 
fits
the *shortest* dimension and thus fills the frame entirely).

I'm attaching a patch which achieves this (though without making it 
configurable,
which you'll probably want to add).  It also modifies the transition to fade 
out the
old image even when 'overlap' is not true, which was needed to get the 
transition to
look reasonable when using a mix of image sizes.

Thanks for all your work on such a solid product.  We're almost ready to 
release the
new Plone slideshowfolder incorporating the newest slideshow.js.

Original comment by dgl...@gmail.com on 8 Jul 2008 at 2:38

Attachments:

@GoogleCodeExporter
Copy link
Author

This should be incorporated now in SVN - thank you!

Original comment by aeron.gl...@gmail.com on 19 Jul 2008 at 9:21

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant