Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML data doesn't use full image srcs or attached thumbnails #33

Closed
GoogleCodeExporter opened this issue May 6, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

I found two parts of slideshow that don't really make sense when using HTML for 
the data section 
(e.g. data is null).

1 - the path of slide image src's still use the hu: option for image paths.  
You should just read and 
use the full image src, since it's already defined in HTML

2 - the thumbnails in the HTML aren't actually parsed.  The image srcs from the 
slideshow-images 
section are still manipulated in with the replace: option, instead of just 
reading the thumbnail 
images from HTML.  That seems wrong.

I've attached my "patch" - really, just a diff, since I'm using git now.  Let 
me know if you guys start 
using Git/GitHub, and I'll make it a real patch.

Original issue reported on code.google.com by m3mo...@gmail.com on 17 Jul 2008 at 5:24

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks! I will definitely be incorporating this!

Original comment by aeron.gl...@gmail.com on 17 Jul 2008 at 5:46

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Thanks! This has been incorporated in SVN.

Original comment by aeron.gl...@gmail.com on 19 Jul 2008 at 9:05

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant