Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering a compostable item with a value higher than one #13

Open
OroArmor opened this issue Mar 7, 2024 · 2 comments
Open

Registering a compostable item with a value higher than one #13

OroArmor opened this issue Mar 7, 2024 · 2 comments

Comments

@OroArmor
Copy link

OroArmor commented Mar 7, 2024

What versions are you playing on?

BtW 1.2
Minecraft 1.20.1
Fabric API quilted_fabric_api - 7.5.0+0.91.0-1.20.1
GeckoLib 4.4.2

What the issue is?

On Quilt, registering an item with a compost chance above one causes an error to be thrown. The range for items is only 0 - 1, so there is no need set it to 2. In addition, you should call CompostingChanceRegistry.INSTANCE.add() from Fabric API instead of injecting into CompostingBlock and adding it yourself.

How to reproduce it?

Run on Quilt.

Other info

image
Fabric API CompostingChanceRegistry

@OroArmor
Copy link
Author

Anyone there? This is a fairly simple issue to fix and I would love to have Beneath the Wetlands working on Quilt.

@Sunconure11
Copy link

I'm trying to get the attention of the staff myself @OroArmor, since I helped them a bit with structures on 1.19.2, so that they work in modded biomes.

You think you could do a mixin-based fix for 1.19.2 - 1.20.1 until the staff become active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants