-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with fullscreen Crunchyroll (using Susbtital) #1015
Comments
Thank you! Sure, I can have a look at that. Can you point me to some suitable content on Crunchyroll to test with? And can I check which browser you are using? |
@birtles thanks so much! You can try with https://www.crunchyroll.com/watch/GR49GM4W6/to-you-2000-years-in-the-future--the-fall-of-zhiganshina-1 (Attack on Titian, ep 1) and the Substital add-on/extension with the attached SRT subtitle file (just change the file extension to .srt so the add-on will recognize it): Though really any SRT file will work for this, since it doesn't matter for 10ten if it matches the video. One thing I noticed is that if you don't have a Crunchyroll account, you may need to wait for the ad to finish playing first before you can use Substital to apply the SRT file to the video. The Attack on Titian, ep 1 is viewable without an account, though. I tested on a Windows 10 machine with both Firefox (version 107.0.1, 64-bit) and Chrome (version 107.0.5304.122 (Official Build) (64-bit)). I tend to use Chrome more for this, but the issue with 10ten in full-screen is present in both. |
Should be fixed in the next release. Thanks! |
Thank you! |
I used the Substital plugin to add Japanese subtitle files to Crunchyroll videos, and 10ten will correctly work when not in full-screen mode, but in full-screen I get the highlight but no popup.
Working:
![working](https://user-images.githubusercontent.com/2301101/204937618-6050f321-1399-4eee-8c94-7df6cb2abeaa.png)
Full-screen not working:
![fullscreen-not-working](https://user-images.githubusercontent.com/2301101/204937626-d6bd9614-e22d-4027-b6e1-355013f92478.png)
It seems like a similar issue was fixed in version 1.9.0 for Netflix (#466), so I was wondering if it might be possible to fix for this as well.
The text was updated successfully, but these errors were encountered: