Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with fullscreen Crunchyroll (using Susbtital) #1015

Closed
deliana-d opened this issue Dec 1, 2022 · 4 comments
Closed

Not working with fullscreen Crunchyroll (using Susbtital) #1015

deliana-d opened this issue Dec 1, 2022 · 4 comments

Comments

@deliana-d
Copy link

deliana-d commented Dec 1, 2022

I used the Substital plugin to add Japanese subtitle files to Crunchyroll videos, and 10ten will correctly work when not in full-screen mode, but in full-screen I get the highlight but no popup.

Working:
working

Full-screen not working:
fullscreen-not-working

It seems like a similar issue was fixed in version 1.9.0 for Netflix (#466), so I was wondering if it might be possible to fix for this as well.

@birtles
Copy link
Member

birtles commented Dec 1, 2022

Thank you! Sure, I can have a look at that. Can you point me to some suitable content on Crunchyroll to test with? And can I check which browser you are using?

@deliana-d
Copy link
Author

@birtles thanks so much!

You can try with https://www.crunchyroll.com/watch/GR49GM4W6/to-you-2000-years-in-the-future--the-fall-of-zhiganshina-1 (Attack on Titian, ep 1) and the Substital add-on/extension with the attached SRT subtitle file (just change the file extension to .srt so the add-on will recognize it):
Attack on Titan.S01E01.JA.txt

Though really any SRT file will work for this, since it doesn't matter for 10ten if it matches the video.

One thing I noticed is that if you don't have a Crunchyroll account, you may need to wait for the ad to finish playing first before you can use Substital to apply the SRT file to the video. The Attack on Titian, ep 1 is viewable without an account, though.

I tested on a Windows 10 machine with both Firefox (version 107.0.1, 64-bit) and Chrome (version 107.0.5304.122 (Official Build) (64-bit)). I tend to use Chrome more for this, but the issue with 10ten in full-screen is present in both.

@birtles birtles closed this as completed in 81d8779 Dec 1, 2022
@birtles
Copy link
Member

birtles commented Dec 1, 2022

Should be fixed in the next release. Thanks!

@deliana-d
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants