Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESGF CWT API extension #102

Closed
huard opened this issue Jan 29, 2019 · 14 comments · Fixed by #106
Closed

Support ESGF CWT API extension #102

huard opened this issue Jan 29, 2019 · 14 comments · Fixed by #106
Assignees
Labels
ESGF Earth System Grid Federation OGC
Milestone

Comments

@huard
Copy link
Contributor

huard commented Jan 29, 2019

Description

WPSClient does not support the owslib esgfapi objects.

@tomLandry tomLandry added the OGC label Jan 29, 2019
@tomLandry
Copy link

tomLandry commented Jan 29, 2019

Let's keep this issue alive. This ideally needs to be documented in the OGC engineering report for our Testbed-14 extension for DOE. By the way, OGC would like to have experiments delivered through notebooks. That's our chance for Birdy.

@huard
Copy link
Contributor Author

huard commented Jan 29, 2019

So for your info Carsten has a branch in owslib to support the extension and a notebook example. Still needs some work but the basics are working. It's only the birdy.WPSClient part that needs to be updated to add support. I won't be able to spend time on this until a few weeks.

@tomLandry
Copy link

Ok, so tagging @davidcaron on this one. It's helping for PAVICS-Hydro too, right?

@cehbrecht cehbrecht added this to To do in San Francisco: Spring 2019 Release via automation Jan 29, 2019
@huard
Copy link
Contributor Author

huard commented Jan 29, 2019

There are no immediate plans to support the ESGF-API extension in the proposal, but this is something that could be contributed as part of the maintenance and improvements.
@davidcaron The first step would be to review the API document
Then review the esgfapi branch of owslib (it's a first pass).
Then add support for those objects in birdy.

@cehbrecht cehbrecht added this to the 0.6.0 milestone Jan 29, 2019
@huard huard added the ESGF Earth System Grid Federation label Jan 29, 2019
@cehbrecht
Copy link
Member

Link to owslib esgfwps branch and notebook example:
https://github.com/bird-house/OWSLib/tree/esgfwps/examples/notebooks

@huard
Copy link
Contributor Author

huard commented Feb 4, 2019

branch fix-102 fixes some issues with non-python ids.
Adding tests for ESGF-API objects.

@huard
Copy link
Contributor Author

huard commented Feb 4, 2019

Next step would be to repeat https://github.com/bird-house/OWSLib/blob/esgfwps/examples/notebooks/owslib-aims-llnl-demo.ipynb with birdy.
Will possibly require some work with headers and token apis.

@cehbrecht
Copy link
Member

If we make owslib.esgfapi an optional dependency we could merge branch fix-102 to master ... when ready.

@huard
Copy link
Contributor Author

huard commented Feb 5, 2019

@cehbrecht It's not great though to rely on an owslib branch. Do you think the owslib folks would agree to a directory of "extensions" ?
E.g. owslib.wps.ext.esgf or owslib.ext.wpsesgf ?

@cehbrecht
Copy link
Member

I can't say if owslib people will accept. The ESGF-API is not a standard. Technically we could start an owslib esgf-api extension on birdhouse which could be optionally installed . We would avoid the insallation issue (relying on a branch) and we get some more time to tune the ESGF-API before it goes into owslib.

@huard
Copy link
Contributor Author

huard commented Feb 5, 2019

Sounds good.

@cehbrecht
Copy link
Member

Ok, I can make a start this week.

@huard
Copy link
Contributor Author

huard commented Feb 5, 2019

Ok, I'll put in some time to write the aggregate process.

@cehbrecht
Copy link
Member

@huard are you ok with the following names?

  • package/repo: OWSLib-esgfwps
  • python module: owslib/ext/esgfwps

@cehbrecht cehbrecht mentioned this issue Feb 15, 2019
San Francisco: Spring 2019 Release automation moved this from To do to Done Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESGF Earth System Grid Federation OGC
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants