fix datatype for boolean values #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cehbrecht
added this to In progress
in San Francisco: Spring 2019 Release
via automation
|
@fmigneault not a nice patch ... but it currently works for me. |
fmigneault
reviewed
May 18, 2019
There was a problem hiding this comment.
The only problem I find with this is that if the field is accessed with service['public'] instead of service.public, we get different values. I have used overrides of __getattr__ in previous projects to solve exactly this potential issue.
Maybe I can dig them up if we feel this becomes problematic here.
| @@ -50,7 +50,10 @@ def has_purl(self): | |||
| def public(self): | |||
| """Flag if service has public access.""" | |||
| # TODO: public access can be set via auth parameter. | |||
| return self.get('public') or False | |||
| value = self.get('public', False) | |||
| if value is True or value == 1 or value == 'true': | |||
There was a problem hiding this comment.
Maybe use pyramid.settings.asbool which handles more use cases, but this is still ok for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite does not handle boolean values and we use integer. This PR tries to handle the boolean parameter handling (public, verify) for both sqlite and postgres.