Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't lose config if provided directly (#69) #73

Merged
merged 1 commit into from May 17, 2019
Merged

don't lose config if provided directly (#69) #73

merged 1 commit into from May 17, 2019

Conversation

fmigneault
Copy link
Contributor

@fmigneault fmigneault commented May 16, 2019 •
edited

  • modify inputs to use allowed types
  • preserve configurator that could already contain some included config from previous calls (owsproxy adapter fails #69)

@cehbrecht cehbrecht added the bug label May 17, 2019
@cehbrecht cehbrecht added this to In progress in San Francisco: Spring 2019 Release via automation May 17, 2019
@cehbrecht cehbrecht added this to the 0.5.0 milestone May 17, 2019
@cehbrecht cehbrecht self-requested a review May 17, 2019 11:35
cehbrecht
cehbrecht approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cehbrecht
Copy link
Member

Fix #69.

@cehbrecht cehbrecht merged commit 07f3123 into bird-house:master May 17, 2019
San Francisco: Spring 2019 Release automation moved this from In progress to Done May 17, 2019
@cehbrecht
Copy link
Member

@fmigneault merged. Thanks :)

@cehbrecht cehbrecht mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cehbrecht cehbrecht cehbrecht approved these changes

Assignees
No one assigned
Labels
bug
Projects
No open projects
San Francisco: Spring 2019 Release
  
Done
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmigneault @cehbrecht