feat: add optional attr support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, checks on node 12 failed, probably because I used |
ericcornelissen
requested changes
Feb 20, 2023
There was a problem hiding this comment.
Thanks for the contribution @tivac. The code changes looks pretty good already, I just have two suggestions for improvements.
Oops, checks on node 12 failed, probably because I used
??. I'll update here in a bit.
Thanks for pro-actively updating based on the CI results!
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
ericcornelissen
approved these changes
Feb 22, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ericcornelissen
requested changes
Feb 23, 2023
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
ericcornelissen
approved these changes
Feb 24, 2023
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Adds support for appending a
?to the end of an attribute config entry to make it optional. Optional attributes will be checked if they exist, but if they are missing andrule::whitelistis set it will not fail validation.I'll update docs once this looks good to a maintainer.