fix: support running CLI in project without config file #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the CLI tests to include a test for the case where a project does not have a configuration file. This test currently fails because this is currently not supported due to a bug introduced in v2.2.0. To accomodate testing this, the configuration file that was present at the root of the project has been moved and related tests updated accordingly. This is necessary because svglint automatically searches for a configuration file up the file tree, so having a configuration file at the root of the project makes it impossible to test the scenario The new tests matches against a string because unfortunately the error is silent - it doesn't exit with a non-zero exit code. Improvements to this are welcome as contributions.
Update the CLI to work if no configuration file is found.
This is the simplest fix I could think of. Theoretically the problem
could be addressed in the API (svglint.js line 137 and 150) by replacing
the default parameter `config={}` with an implementation that defaults
to an empty object for both `undefined` **and** `null`. However, it's
currently not clear that's the right move.
Another alternative would be for `loadConfigurationFile` to return
`undefined` instead of `null`. However, that could interfere with the
intended behaviour of that function, making it impossible to distinguish
a missing default export from no-configuration-file-found.
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
luciansmith
added a commit
to biosimulations/biomodels-qc
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78
Supersedes #79
Re-add support for running the CLI in a project without a configuration file. This worked up to and including v2.1.1 but was broken by the changes of #64.
89ec927 adds a regression test where the CI demonstrates it can catch this bug in the future. 642ea76 fixes the bug itself.
\cc @luciansmith