Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian and Turkey currencies #2

Merged
merged 1 commit into from Jan 7, 2014
Merged

Added Russian and Turkey currencies #2

merged 1 commit into from Jan 7, 2014

Conversation

parhamfh
Copy link
Contributor

@parhamfh parhamfh commented Jan 3, 2014

According to Russian Rubles and Turkish Lire are now available:

https://developer.paypal.com/docs/classic/api/currency_codes/
https://developer.paypal.com/docs/classic/api/country_codes/

web repo also needs to be updated, so taking care of that in a separate repo (not completely sure if I've found all things which need to be added there), but I am guessing this is all that needs to be done for this repo?

@parhamfh
Copy link
Contributor Author

parhamfh commented Jan 3, 2014

@birknilson does countries.py also need to be updated? The COUNTRIES mapping doesn't contain Russia or Turkey for instance.

@birkjernstrom
Copy link
Owner

Yes, in case they are made available by PayPal. The countries where retrieved from a list PayPal provided. Not sure they support all countries for instance - which is why some might not be available in countries.py. Ping @parhamfh

birkjernstrom added a commit that referenced this pull request Jan 7, 2014
Added Russian and Turkey currencies
@birkjernstrom birkjernstrom merged commit b865225 into birkjernstrom:master Jan 7, 2014
@parhamfh
Copy link
Contributor Author

https://developer.paypal.com/docs/classic/api/country_codes/

According to this they both seem to be supported.

In countries.py I see the COUNTRIES map, so I am guessing that Turkey and Russian Federation needs to be added to that since it is a part of the frozenset further down. However, does SUPPORTED_LOCALES (already has Turkish it seems) also need to be updated?

Also, I am curious about ORDER, not quite sure if that is manually formatted or automatically generated, but it seems to contain RU and TR already. What is its purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants