Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation/KO directory and add Korea doc. #84

Conversation

lionking6792
Copy link
Contributor

@lionking6792 lionking6792 commented Nov 8, 2019

I added 'documentation/KO' directory and add Korean version of 'README.md 'to 'documentation/KO'.
I worked in improvement/new-readme branch!

If i haven't catch anything that PR requirements, please comment me!

Thank you! and I hope this will be merge!!

Thanks :)

I added 'documentation' directory and add Korean version of 'README.md 'to 'documentation'.
@lionking6792 lionking6792 changed the title Add documentation directory and add Korea doc. Add documentation/KO directory and add Korea doc. Nov 8, 2019
@bisguzar
Copy link
Owner

bisguzar commented Nov 8, 2019

Please feel free to adding your name to contributors section as translator. I will merge it after full translation. Thank you so much ^^

Add all Korean Translated files on documentation/KO directory.
@lionking6792
Copy link
Contributor Author

lionking6792 commented Nov 8, 2019

I added all Korean tranlated version of this repository!!

Thank you for giving me the chance to translate and I'm honored to be in your project's committer!!
I hope this would be merge!!

Really appreciate to you and thanks!

Copy link
Contributor Author

@lionking6792 lionking6792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contributer name

@bisguzar
Copy link
Owner

Hi @lionking6792 , I was a bit busy. I added missing lines finally. Can you translate them too? And what do you think about creating a docs folder in root and move your readme to there as language code like en_GB.md.

And we are not have to translate comment lines. We can not storage source files for every language :/

@lionking6792
Copy link
Contributor Author

Hi @bisguzar , I agree about your idea! I'll do it 10 hours later after I sleep! Korea is 4 a.m. now. :)

And, I'll add new PR for that!! Thank you for your comment! I'm little bit busy next week, so I hope you see new PR within this week.

Thanks :)

@lionking6792
Copy link
Contributor Author

lionking6792 commented Nov 19, 2019

I PR new one right now! Please check it!!

related #85

@bisguzar
Copy link
Owner

resume in #85

@bisguzar bisguzar closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants