Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing branch python3 errors #98

Open
cahein opened this issue Dec 10, 2021 · 3 comments
Open

testing branch python3 errors #98

cahein opened this issue Dec 10, 2021 · 3 comments
Labels
Needinfo More info required to solve this

Comments

@cahein
Copy link

cahein commented Dec 10, 2021

There is a problem left to fix in branch testing, resulting from upgrade changes in base64. Made minimal fixes in fork cahein/sopare. Didn't test it with python2. For python2 it would likely require an isinstance test of the result from base64.b64encode(obj_data).

@bishoph
Copy link
Owner

bishoph commented Dec 17, 2021

Thx for the fix.

Can you please provide some more information about used OS/versions etc. as with my versions everything seems to run just fine. Also some kind of step by step how to reproduce description.

@bishoph bishoph added the Needinfo More info required to solve this label Dec 17, 2021
@cahein
Copy link
Author

cahein commented Dec 18, 2021

Thanks for writing SoPaRe!

Running on debian bullseye. The error came up, when working with the dict.json.
base64.b64encode has a different return type in python2 (string) and python3 (bytes).

ptyhon3.8/library/base64.html
base64.b64encode(s, altchars=None)
Encode the bytes-like object s using Base64 and return the encoded bytes.

python2.7/library/base64.html
base64.b64encode(s[, altchars])
The encoded string is returned.

@bishoph
Copy link
Owner

bishoph commented Dec 18, 2021

Thanks for the clarification. Ok, I need to install and setup a clean new system. Maybe I get this done between the upcoming holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needinfo More info required to solve this
Projects
None yet
Development

No branches or pull requests

2 participants