Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating the screen causes the embedded browser to refresh #40

Closed
ucarion opened this issue Dec 26, 2013 · 3 comments
Closed

Rotating the screen causes the embedded browser to refresh #40

ucarion opened this issue Dec 26, 2013 · 3 comments

Comments

@ucarion
Copy link

ucarion commented Dec 26, 2013

When I visit an article through the app and rotate my screen, the page refreshes (which can cause quite a bit of delay sometimes). The real annoyance with this is that if I look at an article and then click on a link, causing a rotate event will reload first page (that is, the page linked to from HN) is what's loaded, instead of the one I was just on.

Really great job on this app, though. It's a pleasure to use!

@pkillian
Copy link
Collaborator

Confirmed bug; it irritates me too. I'll look into a few different ways to cache a breadcrumb trail in the integrated browser, and fix the rotate issue if I can. I think it's a matter of making sure onOrientationChanged(int) gets triggered and doesn't just naively call a new load of the same document.

Will look into this before the New Year, but don't expect much progress until next week or so.

Thanks!
Patrick

@pkillian
Copy link
Collaborator

pkillian commented Jan 2, 2014

Changes merged with master; should be released to Google Play soon.

Thanks!
Patrick

@pkillian pkillian closed this as completed Jan 2, 2014
@ucarion
Copy link
Author

ucarion commented Jan 2, 2014

Awesome, @pkillian . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants