Search functionality broken with new HN Search endpoint

[pkillian]

Hacker News recently published a new search API that we're not connecting to; this issue is a top priority and will require a bug fix release right away.

https://news.ycombinator.com/item?id=7118496

[bishopmatthew]

Yeah, we need to fix this. If we have to change the search API (and it's not just a matter of changing the endpoint we're connecting to), I would highly recommend we use Retrofit to do it. Actually I have been planning to switch to Retrofit anyways just for the readability / code length benefits anyways.

https://github.com/bishopmatthew/HackerNews/blob/master/src/com/airlocksoftware/hackernews/loader/SearchLoader.java

[pkillian]

I'm in the process of getting a quick bugfix patch out for it, then we can migrate to Retrofit for v2.2.0

[pkillian]

I've got the new API URI endpoints and sample data, all I'd have to do is plug in the mapping from the new JSON format to what we parse.

ETA: tonight by midnight EST unless I run into blockers.

[pkillian]

Resolved by pull request #65; suggest a bugfix rollout with the following version notes:

v2.1.6
Changes since v2.1.3

New features:
- Optional setting to compress all HTTP data
- Chat support courtesy of Gitter.im (http://gitter.im/bishopmatthew/HackerNews)
- Better bug tracking

Bug fixes:
- Fix for search API request failure; search functions as expected
- Fix "no connection" error pop-up when submitting new story
- New story submissions will accurately report submission status
- No longer crashes when not logged in and expired page loaded
- Other crash fixes