Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming of markets everywhere in the app #1201

Closed
ripcurlx opened this issue Jan 16, 2018 · 8 comments
Closed

Use consistent naming of markets everywhere in the app #1201

ripcurlx opened this issue Jan 16, 2018 · 8 comments
Assignees

Comments

@ripcurlx
Copy link
Member

Besides using the market where applicable, we could reduce the use of the currencies, when we add a currency selection as an additional screen on startup for new users.

Especially on the offer screen we have:

  • Offer book for Euro (BTC/EUR)
  • Currency: Euro (EUR) - 11 offers
  • Offers to buy BTC with EUR
  • Offers to sell BTC for EUR
  • I want to sell BTC for EUR
  • I want to buy BTC with EUR
  • BTC/EUR: 12300.45
  • Amount in BTC
  • Price in EUR for 1 BTC

We could use instead:

  • Offer book for Euro (BTC/EUR)
  • Currency: Euro (BTC/EUR)
  • Offers to buy BTC
  • Offers to sell BTC
  • Buy BTC
  • Sell BTC
  • BTC/EUR: 12300.45
  • Price in EUR
@ripcurlx ripcurlx changed the title Improvement: Use consistent naming of markets everywhere in the app Use consistent naming of markets everywhere in the app Jan 18, 2018
@ManfredKarrer
Copy link
Member

Consider difference with Altcoins. If they want to buy ETH it would be to sell BTC but that is no intuitive and confused users in early versions where we just used BTC. Because of that I changed for Altocoins to "Buy ETH (sell BTC)".

@ripcurlx
Copy link
Member Author

Yes, to make the altcoin or different base currency use cases easier to understand we need something like discussed on #1207

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 13, 2018

This would look like for USD:
Before
bildschirmfoto 2018-02-13 um 14 06 58
After
bildschirmfoto 2018-02-13 um 14 24 47

@ghost
Copy link

ghost commented May 3, 2018

The offers to buy / offers to sell is quite confusing in the current version. The table mentions buy, the call to action says sell, then the colours seem to be inverted since the the norm is buy (green-blue) and sell (yellow-red’ish).

I understand the logic of "Here is the list of people buying, why not sell to them" or "Here is the list of people selling, why not buy from them".. But its quite confusing this cross referencing in the UI.

Why not keep it simple and do something like "Buy Offers List, why not buy some too?" or "Sell Offers List, why not sell some too?" and you can cross reference on your own accord.
market

UI/Visuals still to be defined, was just experimenting with possible layouts.

@ripcurlx
Copy link
Member Author

ripcurlx commented May 4, 2018

@diogorsergio Yes, in the new design we tried to get rid of the different labels Buy/Sell labels. As you mention it, I'm also not sure if the color should be the other way round as it is in the screenshot bellow. The other thing we have to think about is what to do in the chart above. There actually the color is correct as they are Buy offers on the left and Sell offers on the right. Not sure if it would get again more confusing if we have a color mix on each side. What do you think @ManfredKarrer ?
bildschirmfoto 2018-05-04 um 13 53 37

@ghost
Copy link

ghost commented May 4, 2018

@ripcurlx If you check the mockup, I tried to solve that issue. The left is for buys in both the chart and the offers table and the right is sell in both as well. This way everything is connect and there's no cross-referencing implied in the UI, but you can still do it in your head.

Current:

Offers to Buy Offers to Sell
[Sell BTC] Buy BTC

I understand the logic of "Here is the list of people buying, why not sell to them" or "Here is the list of people selling, why not buy from them".. But its quite confusing this cross referencing in the UI.


Proposed:

Offers to Buy Offers to Sell
[Buy BTC] Sell BTC

Why not keep it simple and do something like "Buy Offers List, why not buy some too?" or "Sell Offers List, why not sell some too?" and you can cross reference on your own accord.

market

The labels I used in the mockup can be worded differently to better convey this idea.
What do you think?

@ripcurlx ripcurlx self-assigned this Dec 18, 2018
@stale
Copy link

stale bot commented Mar 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Mar 18, 2019
@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants