Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Release preparations for v0.7.0 #1528

Merged

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented May 1, 2018

We need to adapt the current release script to work with the new gradle setup. At the moment it fails during packaging with

Bundler DMG Installer skipped because of a configuration problem: Main application jar is missing.  
Advice to fix: Make sure to use fx:jar task to create main application jar.

@ripcurlx ripcurlx requested a review from cbeams May 1, 2018 17:17
@XuezProject

This comment has been minimized.

@cbeams

This comment has been minimized.

Prior to this fix, running `./package/osx/create_app.sh` produced a
"Main application jar is missing." error. Now the script works as
expected.
@cbeams cbeams self-assigned this May 6, 2018
@cbeams cbeams removed their request for review May 6, 2018 13:44
@cbeams
Copy link
Member

cbeams commented May 6, 2018

@ManfredKarrer, with commit 4a78010, running ./package/osx/create_app.sh now works as expected.

There are some other issues, though, with the new qualified approach to the bundle name, e.g. using CAT to signify Christoph Atteneder. For example, this shows up as the application name in the macOS menu bar. I guess this was all about devising a way that different maintainers can release the application, and I haven't fully caught up on Christoph's plan here. Perhaps we can work through it together / figure out what to do next.

I'll need to sit down with you to discuss this and to work through the other build steps and make sure everything else works as expected. I'll ping you offline to set up some time for this.

@ManfredKarrer
Copy link
Member

Ah cool. I will try it out soon. The bundle name I will revert anyway as I will do the build now.

@ManfredKarrer ManfredKarrer merged commit 4a78010 into bisq-network:master May 11, 2018
@ripcurlx ripcurlx deleted the release-preparations-for-v0.7.0 branch September 5, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants