Refactoring mainviewmodel #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add BalanceModel in core - Add BalancePresentation, DisputePresentation and TradePresentation in core - Remove balance calculation code from MainViewModel to BalanceModel - Move BSFormatter and BSQFormatter to core - Move onTradesChanged to TradeManager - Add CorePresentationModule
- Group TradeManager startup code to initTradeManager - Move applyTradePeriodState and updateTradePeriodState to TradeManager
- Move filter code to CorruptedDatabaseFilesHandler.getCorruptedDatabaseFiles - Add tradeManager.getSetOfAllTradeIds
- Move p2p network setup code code to P2PNetworkSetup - Move wallet setup code code to WalletAppSetup - Move marketPrice code to MarketPricePresentation
# Conflicts: # src/main/java/bisq/desktop/main/MainViewModel.java
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: bisq-network/bisq-common#27
and bisq-network/bisq-p2p#13
and bisq-network/bisq-core#126