Misc fixes and cleanups #1592
Merged
Misc fixes and cleanups #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug with ignored taker check (use peer instead of offer.getMakerNodeAddress()). - Remove redundant tradeStatisticsSet in TradeStatisticsManager - Remove handling for old TradeStatistics objects (since v 0.6.0 not supported anymore) - Use marketPricePresentation.priceFeedComboBoxItems instead of - MainVievModel.priceFeedComboBoxItems. - Replace Authorisation # with Authorisation number. - Remove https://bisq.network/survey and https://bisq.community links in tradeFeedbackWindow text. - Add null checks. - Improve logging. - Cleanup
|
ACK - @ManfredKarrer don't forget to run the tests before pushing 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offer.getMakerNodeAddress()).
supported anymore)
in tradeFeedbackWindow text.
Depends on bisq-network/bisq-core#130