Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency display settings do not affect available offers list #1084

Closed
gdvine opened this issue Dec 12, 2017 · 6 comments
Closed

Currency display settings do not affect available offers list #1084

gdvine opened this issue Dec 12, 2017 · 6 comments

Comments

@gdvine
Copy link

gdvine commented Dec 12, 2017

Steps to reproduce:

  1. Remove some currencies on Preferences tab from "Currencies in market price feed list"
  2. Go to Buy or Sell tab
  3. See that offers including removed currencies are still visible

Expected result:

  • Offers list respects currency filter settings and only shows those offers in which the user is interested.
@dhingra
Copy link
Contributor

dhingra commented Dec 14, 2017

Hello,

Looking forward to contribute ,can I start with this issue?
Thanks
R

@mrosseel
Copy link
Member

@dhingra sure! If you haven't done so already, please follow the dev setup guide: https://github.com/bisq-network/exchange/blob/master/doc/build.md

@gdvine
Copy link
Author

gdvine commented Dec 14, 2017

Thanks Rohit! The magic of open source, woohoo!

@dhingra
Copy link
Contributor

dhingra commented Dec 31, 2017

@gdvine Checked-in code and created PR.

@gdvine
Copy link
Author

gdvine commented Jan 7, 2018

Looks good, thanks again!

@ripcurlx
Copy link
Contributor

Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ripcurlx @mrosseel @gdvine @dhingra