Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Tor features does not announce its hidden service #2010

Closed
freimair opened this issue Nov 30, 2018 · 1 comment · Fixed by #2009
Closed

External Tor features does not announce its hidden service #2010

freimair opened this issue Nov 30, 2018 · 1 comment · Fixed by #2009

Comments

@freimair
Copy link
Member

freimair commented Nov 30, 2018

When testing my external Tor implementation yesterday (during the testing of the 0.9 release candidate) I found, that in its current implementation, jtorctl does not announce a freshly generated ephemeral serivce to the Tor network.

Has been fixed in #2009, however, as jitpack is behaving kind of funny (jitpack/jitpack.io#3572), that fix is not ready to be included into Bisq as of now.

I recommend taking the
- [Enable use of external Tor services](https://github.com/bisq-network/bisq/pull/1935)
off the list of new features, until this issue gets closed by myself.

@ManfredKarrer
Copy link
Member

Sometimes jitpack does not pick up a new version. Adding another dummy commit most time resolves that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants