Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Validation Override in Coin Extensions #2021

Closed
CaveSpectre11 opened this issue Nov 30, 2018 · 3 comments
Closed

Asset Validation Override in Coin Extensions #2021

CaveSpectre11 opened this issue Nov 30, 2018 · 3 comments

Comments

@CaveSpectre11
Copy link
Member

Several coins, likely starting with PIVX, have errors in the the address validation regular expression; notably the leading character check wasn't deducted from the count of the following characters; so the address validation will incorrectly accept 35 character addresses.

The invalid address checks in Test all contain an invalid first character; therefore the only part of the regex tested is that leading character; so while other test addresses were meant to cover length and other invalid characters; none of the test parsing passed the first character test.

@CaveSpectre11
Copy link
Member Author

After submitting, I was going to assign myself the issue, but I think I need to have something done so I can do that.

@CaveSpectre11
Copy link
Member Author

Pushed in #2023

@CaveSpectre11
Copy link
Member Author

Cleaned up my fork and branch. New clean push #2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants