Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet restore at startup causes exception in 1.4.0 #4622

Closed
chimp1984 opened this issue Oct 11, 2020 · 1 comment
Closed

Wallet restore at startup causes exception in 1.4.0 #4622

chimp1984 opened this issue Oct 11, 2020 · 1 comment

Comments

@chimp1984
Copy link
Contributor

chimp1984 commented Oct 11, 2020

Description

Wallet restore at startup causes exception in 1.4.0

Version

1.4.0

Steps to reproduce

Set a wallet pw and store seeds with 1.3.9. Restart with 1.4.0. At initial pw request window click forgot pw, then the screen extends and shows seed recovery fields. enter seeds and click restore.

Expected behaviour

Recovered from seeds.

Actual behaviour

Throws exception.

Additional info

Expects checkState(vRunning); but we have not started wallet configs service (block download) at that moment.

It does not happen after wallet has been migrated, so at a second start with 1.4.0 it works. Because it is only at migration time an issues it does not need to be fixed IMO if a fix is difficult to achieve as it is a very unlikely event and can be resolved with a restart.

java.lang.IllegalStateException: null
	at com.google.common.base.Preconditions.checkState(Preconditions.java:492)
	at org.bitcoinj.core.PeerGroup.stopAsync(PeerGroup.java:1130)
	at org.bitcoinj.core.PeerGroup.stop(PeerGroup.java:1161)
	at bisq.core.btc.setup.WalletConfig.shutDown(WalletConfig.java:471)
@cd2357
Copy link
Contributor

cd2357 commented Oct 13, 2020

Solved in #4631

@cd2357 cd2357 closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants