Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encrypted wallet password prompt when sending funds from BSQ wallet #4719

Closed
pazza83 opened this issue Oct 28, 2020 · 1 comment · Fixed by #4780
Closed

Add encrypted wallet password prompt when sending funds from BSQ wallet #4719

pazza83 opened this issue Oct 28, 2020 · 1 comment · Fixed by #4780

Comments

@pazza83
Copy link

pazza83 commented Oct 28, 2020

Description

Assuming a Bisq user has turned on password protection for their Bisq wallet. The following is true:

When sending BTC from their Bisq wallet they are required to enter their encrypted wallet password.
When sending BSQ from their Bisq wallet they are NOT required to enter their encrypted wallet password.

It would increase Bisq wallet security if encrypted wallet password prompts were shown when sending both BTC and BSQ.

Version

v1.4.2

Steps to reproduce

In Bisq client > DAO > BSQ Wallet > Send

Enter BSQ address, enter amount, press 'SEND BSQ FUNDS'

No password prompt is shown.

Proposed behaviour

In instances were a Bisq user has turned on password protection for their Bisq wallet.

In Bisq client > DAO > BSQ Wallet > Send

Enter BSQ address, enter amount, press 'SEND BSQ FUNDS'

Encrypted wallet Password prompt is shown.

@pazza83
Copy link
Author

pazza83 commented Nov 4, 2020

In addition it would also be beneficial to include a confirmation screen when sending BSQ. In the same way a confirmation is shown when sending BTC.

Confirmation screen would show:

Sending: XX.XX BSQ
From address: B1.....
To receiving address:  B1.....
Required mining fee is:  0.00.... BTC (xx.xx satoshis/byte)
Transaction size: x.xxx kb

The recipient will receive: xx.xx BSQ

Are you sure you want the withdraw this amount?

This would improve usability when sending BSQ by allowing everything to be confirmed prior to sending.

Currently mining fees are not shown when sending BSQ and they can make a significant proportion of the cost when sending small amounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants