Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for External Tor Node #4853

Closed
GIJack opened this issue Nov 26, 2020 · 6 comments
Closed

Feature Request: Support for External Tor Node #4853

GIJack opened this issue Nov 26, 2020 · 6 comments

Comments

@GIJack
Copy link

GIJack commented Nov 26, 2020

Description

For added security some people, perhaps including myself run an external TOR node. There should be an option in settings for IP and Port of TOR Node. I see there is already an area to enter bridge information.

Both of these should be asked on first run, because it is often not safe for some people to run a local TOR node.

@chimp1984
Copy link
Contributor

This is supported already. I am not sure where the docs for that can be found. @m52go Do you know where/if we have documented usage of that?

Both of these should be asked on first run

I dont agree to that. People get confused already enough with so much info at the first start/usage. This would just add more confusion for not tech-savvy users.

@GIJack
Copy link
Author

GIJack commented Dec 4, 2020

It needs to be asked first run because for many people running a local TOR node is not safe.

If this is already supported, its not in settings. There is an option for custom bridge, but not custom node. There is a difference.

@ripcurlx
Copy link
Member

ripcurlx commented Dec 4, 2020

Following tor related command line parameters can be set:

  • torDir
  • useTorForBtc // default true, except for local core node
  • torrcFile
  • torrcOptions
  • torControlPort
  • torControlPassword
  • torControlCookieFile
  • torControlUseSafeCookieAuth
  • torStreamIsolation

I'm also not sure if it is a good idea to ask everyone on startup if they want to manually configure tor. Maybe we could display on first app run a button/link with a 5 sec countdown or so if you want to manually configure tor. For those who just ignore it the app start continues and for those who click on manual configuration they get an extended tor config screen. For all succeeding app starts we don't ask for this anymore.

I don't think we have a specific wiki entry for tor configuration atm. @m52go ?

@GIJack
Copy link
Author

GIJack commented Dec 4, 2020

All of those config keys need to be in the GUI. command line parameters for a GUI app are for debugging, or automation. GUI apps need GUI configs.

Here is an option for first run:
Radio button with two options: "default TOR options", the other is "custom". Default is default. that if you just click through it works.

If you select "custom" you have the ability to set either a bridge or external tor instance.

@m52go
Copy link
Contributor

m52go commented Dec 4, 2020

I don't think we have a specific wiki entry for tor configuration atm. @m52go ?

No, but thank you for outlining them—I'll add.

@ripcurlx
Copy link
Member

ripcurlx commented Dec 9, 2020

Just checked existing issues and I'm closing this one as a duplicate of #3010.

@ripcurlx ripcurlx closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants