Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to take offer after first attempt time out. #5007

Closed
invertedbobb opened this issue Dec 26, 2020 · 4 comments
Closed

Impossible to take offer after first attempt time out. #5007

invertedbobb opened this issue Dec 26, 2020 · 4 comments

Comments

@invertedbobb
Copy link

Description

Whenever i take an offer and it fails for whatever reasons, usually a time out, no funds are spent, no txs are created, but the trade is still considered failed and moved to the failed trades list.
As a result, I'm unable to try to take the offer again at a later point or after switching networks.
This is an issue on the taker-side, I'm able to try again with a new bisq-profile. Just not the one where i tried it before.
This is new behavior and i used to be able to try again if i got a time out.

Version

Bisq v1.5.1

Steps to reproduce

  1. Take offer, hope it fails or disconnect your network immediately after initiating the trade.
  2. Get message that taking the offer failed and no funds have moved from the wallet.
  3. Try to take the offer again, resulting in message, unable to take offer, already in the failed trades list.

Expected behavior

When the offer has not actually been taken and no txs were created, it should not be moved to the failed trades list and should remain available to try to take the offer again.

Actual behavior

Unable to try to take an offer after a first attempt failed with a time out.

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jun 11, 2021
@ripcurlx
Copy link
Member

@invertedbobb Do you see this issue still in the current version?

@stale stale bot removed the was:dropped label Jun 11, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants