[v1.6.3] Bisq requires libpng12 to be pre-installed on Ubuntu later than 16.04

[ripcurlx]

Description

Based on feedback from @paulmercier-bisq and @MwithM on Keybase the new deb bundle causes problems on Ubuntu 16.04+ after version 16.04. It is requiring libpng to be installed upfront.

Version

v1.6.3

Steps to reproduce

Run Ubuntu 16.04+ and try to install/update v1.6.3.

Expected behaviour

App is installed and running.

Actual behaviour

Error: Dependency is not satisfiable: libpng12-0

Device or machine

Ubuntu 16.04+

Additional info

The current workaround is to manually install the required library:

$ sudo add-apt-repository ppa:linuxuprising/libpng12
 $ sudo apt update
 $ sudo apt install libpng12-0

[ripcurlx]

I'll have a look if I can fix it by switching to an up-to-date Ubuntu version for building the deb binary.

[ripcurlx]

I've tried to build a deb binary on a Ubuntu 18 VM: https://www.dropbox.com/s/0bzsam9yv7a1cfk/bisq_1.6.3-1_amd64.deb?dl=0

Unfortunately this didn't solve the problem for @MwithM

@paulmercier-bisq: Could you please test if this binary works for you without the need to install the libpng12 lib?

[cd2357]

I tried it with a fresh updated Ubuntu 16.04 and it had libpng12-0 already installed.

sudo apt-get install libpng12-0
libpng12-0 is already the newest version (1.2.54-1ubuntu1.1).

Bisq 1.6.3 also installed an started with no problem.

Update: this was the x64 desktop iso from http://releases.ubuntu.com/16.04/

Maybe the issue only happens with other versions? (32 bit / server / not a "native" 16.04 but upgraded from prev versions / etc)

[ripcurlx]

It is a problem after 16.04. I should have phrased it correctly. I just created a new build with a Ubuntu 20 VM and manually removed the libpng12-0 lib before and it runs now for me without any problems.

https://www.dropbox.com/s/aq7s29z9rq84u91/bisq_1.6.3-1_amd64-built-without-lippng12.deb?dl=0

[ripcurlx]

Not sure if it would fail now for 16.04- versions?

[paulmercier-bisq]

I've tried to build a deb binary on a Ubuntu 18 VM: https://www.dropbox.com/s/0bzsam9yv7a1cfk/bisq_1.6.3-1_amd64.deb?dl=0

Unfortunately this didn't solve the problem for @MwithM

@paulmercier-bisq: Could you please test if this binary works for you without the need to install the libpng12 lib?

Hello, i just tested it, it seems to run flawlessly with the deb you provided, though what disappoints me is that libpng16-16 is installed by default on Ubuntu 20.04, so i don't see why it would use an older version ? Compatibility issues maybe ?

[cd2357]

Same here, the 2nd deb worked fine on Ubuntu 20.04 (first one failed with the libpng 12 missing error)

[MwithM]

I did not have any error installing (after installing missing dependency), but the path to open Bisq is /opt/bisq/bin/Bisq

[cd2357]

I did not have any error installing (after installing missing dependency), but the path to open Bisq is /opt/bisq/bin/Bisq

Thats probably jpackager abiding by Linux binary path conventions, which diverge from the prev Bisq path /opt/Bisq/Bisq :

• generated binary should be under bin subfolder
• app name should be lowercase in the /opt subfolder /opt/bisq

I'd say we should keep the new path and update the documentation to reflect it.

@ripcurlx @MwithM : would you agree? If yes, I'll prepare a commit to update the documentation.

[ripcurlx]

@ripcurlx @MwithM : would you agree? If yes, I'll prepare a commit to update the documentation.

Yes, please let's update the documentation.

[MwithM]

I have updated the wiki, replacing /opt/Bisq/Bisq for /opt/bisq/bin/Bisq wherever I've found it.

[cd2357]

Thanks @MwithM , you were faster than me :)

I checked the source-code, the release notes, the website repo, and the wiki. All occurrences are already up-to-date.