Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still v2 addresses used in BitcoinJ? #5778

Closed
chimp1984 opened this issue Oct 23, 2021 · 9 comments
Closed

Still v2 addresses used in BitcoinJ? #5778

chimp1984 opened this issue Oct 23, 2021 · 9 comments

Comments

@chimp1984
Copy link
Contributor

I see that error in the logs:

[BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion:8333] WARN org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-10-23 22:28:21, height=706355}: Received unhandled message: org.bitcoinj.core.SendAddrV2Message@2f5d3a99

Looks like there is still usage of v2 addresses?
@ripcurlx any idea?

@cd2357
Copy link
Contributor

cd2357 commented Oct 30, 2021

Getting the same warning when using the BTC node wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion:

Oct-30 14:42:27.156 [BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion/<unresolved>:8333] WARN org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-10-30 14:42:26, height=707422}: Received unhandled message: org.bitcoinj.core.SendAddrV2Message@2374be06

However:

  • NOT getting that warning when using my own node (also via tor v3)
  • NOT getting that warning when using another of wiz's BTC nodes, jto2jfbsxhb6yvhcrrjddrgbakte6tgsy3c3z3prss64gndgvovvosyd.onion

@wiz any difference in setup between wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid and jto2jfbsxhb6yvhcrrjddrgbakte6tgsy3c3z3prss64gndgvovvosyd ? Are they running the same bisq version?

@cd2357
Copy link
Contributor

cd2357 commented Oct 30, 2021

subVer=/Satoshi:0.20.99(@wiz)/

Tor v3 support was added in Bitcoin Core v0.21

@wiz
Copy link
Member

wiz commented Oct 30, 2021

Ah okay, looks like this can be fixed by upgrading that one node. It was a custom build of Bitcoin Core v0.20 before the PR to get Tor v3 supported was merged so it supports both v2 and v3 but if that causes issues I can just remove it.

@cd2357
Copy link
Contributor

cd2357 commented Nov 2, 2021

Sounds good. Let me know when its upgraded, I can then check if this warning is gone.

@ripcurlx
Copy link
Contributor

This has nothing to do with Tor v2 addresses. This is a new P2P message based on https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki that supports Tor v3 addresses. So the naming is a little bit confusing. I looked at the code where this logging takes place and it seems that this is sent from @wiz's node to indicate that it is preferring and understands addrv2 messages. I don't know why it only happens with @wiz node and why it is logged as a warning in that case.

@ripcurlx
Copy link
Contributor

@wiz Did you change anything already with this node, as I still see this warning?

Nov.-10 09:22:14.877 [BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion/<unresolved>:8333] INFO  org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-11-10 09:22:14, height=709044} 
Nov.-10 09:22:14.877 [BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion/<unresolved>:8333] INFO  org.bitcoinj.core.PeerGroup: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-11-10 09:22:14, height=709044}: New peer      (7 connected, 0 pending, 7 max) 
Nov.-10 09:22:14.877 [BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion/<unresolved>:8333] INFO  org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-11-10 09:22:14, height=709044}: Sending Bloom filter and querying mempool 
Nov.-10 09:22:14.878 [BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion/<unresolved>:8333] WARN  org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-11-10 09:22:14, height=709044}: Received unhandled message: org.bitcoinj.core.SendAddrV2Message@58fd0c6f

@wiz
Copy link
Member

wiz commented Nov 10, 2021

Fixing this is in my task queue, however as it's merely a warning in the log prints I am treating this as a low priority issue and will get to it after Taproot activation.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants