Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug at reorgs #5809

Closed
chimp1984 opened this issue Nov 4, 2021 · 0 comments · Fixed by #5819
Closed

Bug at reorgs #5809

chimp1984 opened this issue Nov 4, 2021 · 0 comments · Fixed by #5819

Comments

@chimp1984
Copy link
Contributor

When a reorg happens the app gets in a loop of deleting daoState to get it replaced from resources and requesting new blocks which triggers the cycle again...

I will look into fixing it after the open PRs are merged.
Simple version would be to enforce a restart. Other more complex option is to replace daoState with resources without restart. But that might cause issues in clients if they do not listen to that event and not getting updated.
Not sure how often reorgs happen in Bitcoin, I guess very rarely. If so the restart options seems ok and carries less risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant