Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.8.0] Duplication of BSQ swap offers not supported #5865

Closed
ripcurlx opened this issue Nov 25, 2021 · 2 comments · Fixed by #5886
Closed

[v1.8.0] Duplication of BSQ swap offers not supported #5865

ripcurlx opened this issue Nov 25, 2021 · 2 comments · Fixed by #5886
Assignees
Labels

Comments

@ripcurlx
Copy link
Contributor

When trying to duplicate a BSQ swap offer nothing happens.

Bildschirmfoto 2021-11-25 um 11 18 07

Description

Duplication of BSQ swap offers not possible

Version

master, v1.8.0 release branch

Steps to reproduce

  • Try to duplicate an existing offer in Portfolio > My Open Offers

Expected behaviour

  • BSQ swap offer can be duplicated

Actual behaviour

Nothing happens (not even an error log)

Screenshots

Bildschirmfoto 2021-11-25 um 11 18 07

@chimp1984
Copy link
Contributor

chimp1984 commented Nov 25, 2021

Edit offer and duplication is not supported. Wanted to limit effort and see how much it will be used. Edit offer is also not really needed as BSQ offers have no maker fee at offer creation.

The duplication feature should though be deactivated. But to be honest, it is so hidden that most users are not aware of it anyway I assume.... (right click context menu is usually not used on Bisq as UX element - I think it should be changed to some more visible solution).

@ripcurlx
Copy link
Contributor Author

Edit offer and duplication is not supported. Wanted to limit effort and see how much it will be used. Edit offer is also not really needed as BSQ offers have no maker fee at offer creation.

True - I forgot about that.

The duplication feature should though be deactivated. But to be honest, it is so hidden that most users are not aware of it anyway I assume.... (right click context menu is usually not used on Bisq as UX element - I think it should be changed to some more visible solution).

I personally use it all the time. It is a power user feature, but I think it is a very used one. I'll have a look if I can add the support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants