Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade failed at task TakerVerifyAndSignContract #5916

Closed
dgyg opened this issue Dec 14, 2021 · 6 comments
Closed

Trade failed at task TakerVerifyAndSignContract #5916

dgyg opened this issue Dec 14, 2021 · 6 comments

Comments

@dgyg
Copy link

dgyg commented Dec 14, 2021

Description

Trade failed with An error occurred at task: TakerVerifyAndSignContract at the maker side:

Dec-14 20:17:27.522 [JavaFX Application Thread] WARN  b.c.t.p.b.DisputeProtocol: Received AckMessage with error state for 
InputsForDepositTxResponse from XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.onion:9999 with tradeId 
XXXXX-XXXXXXX-XXX-XXXX-XXXX-XXXXXXXXXX-XXX and errorMessage=An error occurred at task: TakerVerifyAndSignContract
Contracts are not matching 

Version

v1.8.0 (maker)
unkown (taker)

Additional info

Payment Method: National Bank Transfer

Possible related forum thread: https://bisq.community/t/failed-taker-after-v1-8-0/11273

@ghost
Copy link

ghost commented Dec 14, 2021

In your bisq.log it will have listed out both contracts (search for WARN b.c.t.Contract), you can paste them into a diff tool and it will show you what did not match. In previous ones I've seen, it was the % price that was different. Would be useful if you could let us know what is not matching in your case.

Here's an example:

image

@ghost
Copy link

ghost commented Dec 15, 2021

The issue is an incompatibility between old and new Bisq versions due to some fields removed from the trade contract. Expect an update from @ripcurlx soon.

Thankyou for reporting it.

@dgyg
Copy link
Author

dgyg commented Dec 15, 2021

@jmacxx Thanks for your answer

There is no other log statement on Level WARN in my log file around this time. Maybe there is older log configuration active on my machine.

But I found this:

Dec-14 20:09:43.891 [JavaFX Application Thread] INFO  b.c.offer.Offer: Price at take-offer time: 
id=XXXXXX, currency=XXX, takersPrice=4XXXXXXXX, makersPrice=4XXXXXXXX, deviation=0.01659913537079838%

Did the indicated deviation of 0.01659913537079838% triggered the failure?

Interesting is the time difference of 7 minutes and 44 seconds between that statement and the final failure at 20:17:27.

@ghost
Copy link

ghost commented Dec 15, 2021

Ah yes, indeed looking at your original error at the top of this post, it was your trade counterparty that sent a (N)ACK with the error message to you. We're solving this trading incompatibility between versions by making >= v1.8.0 mandatory, older clients will be prompted to upgrade.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant