Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade deposit sometimes not funded from offer maker UTXO (& error shown) #5946

Closed
ghost opened this issue Jan 3, 2022 · 4 comments
Closed

Comments

@ghost
Copy link

ghost commented Jan 3, 2022

Users have reported the error

Error message: Maker/Taker txId in contract does not match deposit tx input

Investigation:

  • Maker has funded the deposit from a UTXO which does not match the reserved tx from the offer payload.
  • Maker paying into the deposit with an odd looking (i.e. random) amount.
  • Over funded, a change output is sent back to the maker's wallet.

The validation check in Bisq expects the two intputs for the deposit linking to maker/taker or taker/maker trade fee UTXO.
Either this is a bad assumption, or there is a bug whereby the maker funds the trade with a different UTXO.


Status: waiting to obtain logs that will show the UTXO selection during offer creation and trade funding.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 16, 2022
@ghost
Copy link
Author

ghost commented Apr 16, 2022

Not stale.

@stale stale bot removed the was:dropped label Apr 16, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants