Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary popup after removing BSQ swap offer #5956

Closed
MwithM opened this issue Jan 7, 2022 · 0 comments · Fixed by #5957
Closed

Unnecessary popup after removing BSQ swap offer #5956

MwithM opened this issue Jan 7, 2022 · 0 comments · Fixed by #5957

Comments

@MwithM
Copy link
Contributor

MwithM commented Jan 7, 2022

Description

After removing a BSQ swap offer, "You can withdraw the funds you paid in from the {0} screen." popup is displayed. As there are no funds paid when a BSQ swap offer is created, I think that this popup is not necessary and might be confusing.

Steps to reproduce

This is not a bug, but a UX issue. To reproduce it:

  1. Create a BSQ swap offer.
  2. Remove it at the open offers tab.

Expected behaviour

No pop-up, or "BSQ swap offer removed" pop-up.

Screenshots

imagen

Additional info

This popups seems to be confusing for normal offers as well. Trading fees are already paid and not reimbursed (this is alerted before removing the offer) but funds into Bisq wallet were never moved or "paid" as they were just reserved by Bisq wallet.
If the intention of the popup text is to remind users that they can withdraw available funds from Bisq wallet anytime, I suggest to use something like "Offer has been removed. Funds are not reserved for this offer anymore. You can send Available funds to an external wallet at Funds - Send Funds".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant