Bitcoin Core v22 deprecated addresses is not handled

[softsimon]

Description

Since Bitcoin Core v22, the Bitcoin API has changed the format of how addresses are returned. So since v22 deprecatedrpc=addresses is required to get the old format and in v23 it's removed completely.

Bisq JSON blocks data export does not seem to handle this transition which breaks the Bisq block explorer if upgrading to the latest versions as addresses are not visible.

Steps to reproduce

Run Bitcoin Core v22 or later with default settings.
Latest Bisq version v1.8.4

Expected behaviour

The address field should be present

Actual behaviour

address is now missing in the JSON data that is dumped.

[boring-cyborg]

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

[wiz]

@chimp1984 would appreciate if you can take a look, currently this is holding up an upgrade of the mempool.space servers since it will break BSQ addresses from displaying on bisq.markets - thanks

[chimp1984]

Ah damn Bitcoin RPC devs keep breaking APIs. @jmacxx could you have a look?

[ghost]

Working on it.

bisq/core/src/main/java/bisq/core/dao/node/full/RpcService.java

Lines 354 to 355 in a384071

	String address = scriptPubKey.getAddresses() != null &&
	scriptPubKey.getAddresses().size() == 1 ? scriptPubKey.getAddresses().get(0) : null;

The following change should fix it:

String address = new Script(Hex.decode(scriptPubKey.getHex()))
    .getToAddress(Config.baseCurrencyNetworkParameters()).toString();

[chimp1984]

Please invite me for review once a PR is ready. DAO code is always a bit risky....

[alkum]

I think it should support both node behaviors (if v <= 22, .., else ..), otherwise RpcService.SUPPORTED_NODE_VERSION_RANGE would have to get more restrictive.

[wiz]

@jmacxx thanks, do you have a PR that I can test out?