Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banned payment accounts #6137

Closed
ghost opened this issue Apr 7, 2022 · 7 comments
Closed

Banned payment accounts #6137

ghost opened this issue Apr 7, 2022 · 7 comments

Comments

@ghost
Copy link

ghost commented Apr 7, 2022

Description

I was using debugger and saw a lot of records in filterManager.getFilter().getBannedPaymentAccounts(). Most of them contains sensitive data like email, username, phone etc. I'm pretty sure I didn't set them manually, so probably they were propagated via P2P network. It seems to be a security issue.

Version

1.8.6

Steps to reproduce

Not reproduceable via UI. Use debugger, stop somewhere where filterManager is available and check filterManager.getFilter().getBannedPaymentAccounts()

Expected behaviour

I'm not sure - propositions:

  • remove banned payment accounts filtering at all,
  • not propagate this data via P2P - only locally,
  • use different field to recognize account (salt?) or use hashing to make this data anonymous
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@pazza83 pazza83 reopened this Oct 16, 2023
@pazza83
Copy link

pazza83 commented Oct 16, 2023

Hi a user has brought this up again.

@alvasw please can you let me know if a solution is feasible

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@pazza83
Copy link

pazza83 commented Jan 15, 2024

Hi @jmacxx is this something you would be able to take on?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant