Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error dialog when firewall is misconfigured #6141

Closed
JeremyRand opened this issue Apr 11, 2022 · 2 comments · Fixed by #6147
Closed

Misleading error dialog when firewall is misconfigured #6141

JeremyRand opened this issue Apr 11, 2022 · 2 comments · Fixed by #6147

Comments

@JeremyRand
Copy link

JeremyRand commented Apr 11, 2022

Description

The error dialog appearing when an offer is open but the firewall is misconfigured to block incoming connections is misleading.

Version

Bisq v1.8.4

Steps to reproduce

  1. Install Bisq on Whonix as per the instructions on the Whonix wiki, but forget to configure the firewall on the Whonix-Workstation VM (thus, incoming onion connections from the Tor daemon to Bisq will be dropped).
  2. Create an open offer.
  3. Wait a week.

Expected behaviour

The error dialog from Bisq should suggest to check the firewall settings (in addition to the other things it suggests).

Actual behaviour

The error dialog from Bisq says:

Important private notification!

You might need to clear your tor cache / restart your Bisq instance, as your 2 offers have not been reachable for at least a week.

To do that from the Bisq application menus:
Settings -> Network Info -> Open Tor Settings -> Delete Outdated Tor Files and Shutdown

It does not suggest checking the firewall settings, thus users who have a misconfigured firewall will go on a wild goose chase and not find the actual problem.

Screenshots

N/A; issue is with text, not graphical.

Device or machine

Haswell i7; Whonix 16 inside Qubes 4.1.

Additional info

In my experience, firewall misconfiguration is a very common newbie error, and it's often not obvious to newbies that this is something they need to check.

@ghost
Copy link

ghost commented Apr 12, 2022

@bisq-network/bisq-devs Any idea how we could reproduce this issue using popular linux firewalls (iptables, ufw)?

@Emzy
Copy link
Contributor

Emzy commented Apr 13, 2022

The problem is that your setup runs not the included tor from Bisq.

I'm against changing the message. This will otherwise mislead normal users without special Tor setup on Qubes OS / Whonix.

The clarification is better put in the Whonix wiki. (https://www.whonix.org/wiki/Bisq)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants