Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Market/OfferBook: Highlight user's own offers #6171

Closed
ahmogit opened this issue Apr 26, 2022 · 2 comments · Fixed by #6188
Closed

In Market/OfferBook: Highlight user's own offers #6171

ahmogit opened this issue Apr 26, 2022 · 2 comments · Fixed by #6188

Comments

@ahmogit
Copy link

ahmogit commented Apr 26, 2022

Description

In Market/OfferBook, the user's own offers are visually identical in format wih everyone else's. It would be nice to visually distinguish them in some way, e.g. highlighting or outlining.

Why? Because the icons currently used to identify users are too small to visually differentiate without zooming in. It's not easy to tell who is "you". Many icons appear nearly identical from typical screen viewing distance. Highlighting one's own offer lines would be helpful. (Or, as a more general solution: Replace the existing user icons with a more orthogonal and visually differentiable set, so that you can distinguish your own icon more easily from others)

Version

1.8.4

Steps to reproduce

Make offer. Open Market/OfferBook view.

Desired behaviour

Highlight or somehow distinguish user's own offers in Market/OfferBook view

Actual behaviour

User's own offers appear idential to everyone else's (afaict)

Device or machine

Arch linux, commodity laptop.

@ripcurlx
Copy link
Contributor

If you go to the actual offerbook where you can take offers, your own offers will jump out as they have the option to be deleted or edited.

@ahmogit
Copy link
Author

ahmogit commented Apr 27, 2022

I'm aware of that, but it doesn't really address what I had asked for, which was to highlight the user's own trades directly on the Market/OfferBook screen, so they can be observed simultaneously with the offer volume plot, which displays the current spread situation.

The view that you're talking about is one level deeper than the Market/OfferBook view itself, and it does not actually show the full offer book; it shows only either buy-side orders or sell-side offers, and also does not display the volume chart. So if you have open orders on both sides, you can't see both, only one set. This is exactly the reason for asking that the user's offers be highlighed on the Market/OfferBook screen, i.e. so that the user can see all of his offers within the context of the current spread situation (which is only understandable if you can see both sides of the book.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants