Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differenciate offer removal pop-ups for BSQ swaps and regular trades #6529

Closed
MwithM opened this issue Jan 19, 2023 · 0 comments · Fixed by #6537
Closed

Differenciate offer removal pop-ups for BSQ swaps and regular trades #6529

MwithM opened this issue Jan 19, 2023 · 0 comments · Fixed by #6537

Comments

@MwithM
Copy link
Contributor

MwithM commented Jan 19, 2023

Description

Removing a BSQ swap offer deactivating the popup that asks if you want to remove an offer with the "don't ask me again" button, also deactivates the pop-up for regular offers, which causes trading fees to be lost.

Version

1.9.9

Steps to reproduce

  • Click the Reset all Don't show again flags on Settings.
  • Create BSQ swap offer.
  • Remove the offer. A pop-up is displayed. Click "don't ask me again" on the pop-up.
  • Create regular (alts, fiat) offer.
  • Remove the offer. No pop-up is displayed. Offer is removed, trading fees lost.

Expected behaviour

Another pop-up is displayed, even if "don't ask me again" was checked for BSQ swaps.

Actual behaviour

Offer is removed without pop-up and no info about losing trading fees is displayed.

Screenshots

image
Are you sure you want to remove this offer? No trading fees will be paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant