Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitstamp bug: miscalculates % distance from market price #823

Closed
fresheneesz opened this issue May 25, 2017 · 7 comments
Closed

Bitstamp bug: miscalculates % distance from market price #823

fresheneesz opened this issue May 25, 2017 · 7 comments

Comments

@fresheneesz
Copy link

I'm trying to do this trade:

bitstamp distance from market bug

It says its 99.02% from market price, which seems correct to me. However, when I press next step, it pops up a blocking warning that says "The price you have entered is outside the max. allowed deviation from the market price. The max allowed deviation is 10.00%..."

So.. 99.02% seems like less than 1% off market price - clearly not over 10%. So what's going on here?

@fresheneesz
Copy link
Author

Ok I figured this out. The error message made things as clear as mud. It would have been nice if it had said the percentage over the market price in that error message. I thought "distance in % from market price" was "percent of market price" - i wanted to list something 99% of market price (1% distance). Better error message or titling is needed here

@Piste
Copy link

Piste commented Jul 12, 2017

This wording also got me tripped at first. Maybe a display of a quick calc of what the price could be at the time of placing a bid or ask could help. Indicative.

EDIT: More visually, I'd display an estimated price, in grey, to the right of the percentage sign in the screenshot above.

@ManfredKarrer
Copy link
Member

Thanks for the input. As soon we have a dedicated UI dev we will re-work that screen.

@stale
Copy link

stale bot commented Jan 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 18, 2019
@stale
Copy link

stale bot commented Jan 25, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Jan 25, 2019
@fresheneesz
Copy link
Author

I really question the value of closing stale tickets. Does this bug still exist? Why close this ticket if the bug persists?

@ripcurlx
Copy link
Contributor

@fresheneesz That is actually what this auto-stale is all about. Issues with labels like a:bug will never be closed. Just tickets that didn't have any activity for 90 days. We want to have an issue handling that important stuff is not buried below issues that might be fixed already or are not that important. In this case the UI changed quite a bit already. Next to the percentage value there are now indication/warning symbols explaining if your selling to or against your advantage. If that is not sufficient from your point of view, feel free to re-open this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants