Remove edit button for BSQ offers #6679
Conversation
desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java
Outdated
Show resolved
Hide resolved
napoly
force-pushed
the
fix_hide_edit_button_bsq_offer
branch
from
a09b3e0
to
fc42044
Compare
There was a problem hiding this comment.
NACK
As far I remember the edit button worked for BSQ offers as @pazza83 commented in #6668 (comment). We should figure out what caused it to not work anymore.
|
I did some digging since I'm new to the code base, and it appears that the functionality is not available. This is supported by the fact that it was removed from even the open offers, as shown here: https://github.com/bisq-network/bisq/blob/master/desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersView.java#L1007 |
There was a problem hiding this comment.
NACK
After further debugging, I can confirm that the edit BSQ offer functionality is present.
When I press the edit button on a BSQ offer first it opens the edit tab:
However, there are several bugs:
- Pressing to fast on the edit button trigger a
java.util.ConcurrentModificationExceptionexception - Pressing the edit button on an BSQ offer breaks other offers edit buttons
- Sometimes the edit button doesn't even open the edit tab
|
This bug needs to get fixed, and @napoly has done correctly what was requested/required. I will second what @ripcurlx said in #6668 (comment) that there is no edit of BSQ swap offers and the best thing would be to remove the edit button for BSQ offers, as implemented above. The screenshot Alva produced is the edit dialog for original (multisig) offers which is incompatible with BSQ swaps. There's not much sense trying to adapt it for BSQ swaps, as the offer UI code is complex / fragile / sensitive to change. |
|
@jmacxx You are totally right!! Sorry. |
Fixes #6668
We use a simple 'if' check to determine if our offer is for a BSQ swap. If it is, we do not show the button for editing.