Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show AmazonGC country in offer book. #6777

Merged
merged 1 commit into from Jul 25, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2023

Closes #6661

image

@pazza83 Is this scenario ok?

  • Maker creates an offer to Buy BTC with his Amazon(FR) account.
  • Seller takes the offer with his Amazon(NL) account.
  • Bisq prompts the buyer to Buy giftcard at amazon.nl, country Netherlands (NL) :

image

@pazza83
Copy link

pazza83 commented Jul 20, 2023

Hi @jmacxx

Looks good.

What about when the Maker is the BTC seller?

I think is should be as follows:

Maker as BTC buyer:

  • Maker creates an offer to Buy BTC with his Amazon(FR) account.
  • Seller takes the offer with his Amazon(NL) account.
  • Bisq prompts the buyer to Buy giftcard at amazon.nl, country Netherlands (NL) :

Maker as BTC seller:

  • Maker creates an offer to Sell BTC with his Amazon(FR) account.
  • Buyer takes the offer with his Amazon(NL) account.
  • Bisq prompts the buyer to Buy giftcard at amazon.fr, country France (FR):

This way the BTC Seller always receives the gift card in the currency of their choice.

If implemented I will update the wiki to make sure it is clear this is how it works for EU offers.

@ghost
Copy link
Author

ghost commented Jul 20, 2023

Yes that's the two scenarios. I was uncertain about the first one because it seems a bit confusing. The BTC seller taker from (NL) might think they cannot take the offer because the it says Amazon(FR). But if its explained well in the wiki then all good.

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit cbfc68b into bisq-network:master Jul 25, 2023
13 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Jul 25, 2023
@ghost ghost mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon EUR doesn't show country code for gift cards.
2 participants